-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing "Unique" and "Enforce Unique constraint" error message #3520
Conversation
Pull Request Test Coverage Report for Build 9647956985Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9647956985Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9648156091Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9648156091Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9648156091Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9665778385Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9665778385Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9665778385Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments
Pull Request Test Coverage Report for Build 9680031228Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are getting there, there should be only two things left to do.
- Fix gallery, please open the gallery - page 'editors'. There are some errors due to these new properties
- When
shouldShowValidationMsg
isfalse
, we should keep thevalidation
statevalid
. For this we simply need to adjust the condition for theValid
state of thevalidationStateGroup
to consider also theshouldShowValidationMsg
flag. ... MaybeshouldShowValidation
would be a better name then :)
Pull Request Test Coverage Report for Build 9714183687Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9714896853Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 9714896853Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9714896853Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! 🚀
'Unique' and 'Enforce Unique Constraint' error message would not work when 'Apply Default Value on Update' option was checked after setting a 'Default Value' in 'Defaults' tab.
Fixes #3457